Hello! I have written two blocks of code that extracts the BCG ID from the Halo ID, and another bloc of code that extracts the subhalo IDs within a given halo. I am not sure I completely understand what I did and if I am utilizing GroupFirstSub properly. Any feedback would be greatly appreciated!
Dylan Nelson
13 Feb
This looks fine, is there some problem?
You shouldn't need int() everywhere, all these IDs are already ints.
I would suggest to avoid words like "Cluster" and "BCG", just keep in direct, and either always use "Halo" and "Subhalo". If by BCG you mean "central subhalo" or "first subhalo", keep it at that.
Hello! I have written two blocks of code that extracts the BCG ID from the Halo ID, and another bloc of code that extracts the subhalo IDs within a given halo. I am not sure I completely understand what I did and if I am utilizing GroupFirstSub properly. Any feedback would be greatly appreciated!
This looks fine, is there some problem?
You shouldn't need
int()everywhere, all these IDs are already ints.I would suggest to avoid words like "Cluster" and "BCG", just keep in direct, and either always use "Halo" and "Subhalo". If by BCG you mean "central subhalo" or "first subhalo", keep it at that.